This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Write signing keys with file mode 0640 #16740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabian Klemp <[email protected]>
elara-leitstellentechnik
force-pushed
the
develop
branch
from
67b023d to
c18e86b
Compare
elara-leitstellentechnik
changed the title
elara-leitstellentechnik
force-pushed
the
develop
branch
from
e3d9426 to
25baa4d
Compare
DMRobertson
reviewed
Dec 8, 2023
DMRobertson
suggested changes
Dec 8, 2023
There was a problem hiding this comment.
The changes look good. But I think there is one more place that we generate and write signing keys:
synapse/synapse/_scripts/generate_signing_key.py
Lines 24 to 37 in 961ee75
(I found this by searching for uses of write_signing_keys).
Could you also amend this one? Probably the easiest way is to append
if args.output_file is not sys.stdout:
os.chmod(args.output_file, 0o640)to the end of main. Hopefully it should be easy test, too by running the script.
|
Your suggestion doesn't work as the type of I therefore refactored the script a bit. This has the nice benefit, that the file is properly closed now as well (which I believe it wasn't before. |
Signed-off-by: Fabian Klemp <[email protected]>
elara-leitstellentechnik
force-pushed
the
develop
branch
from
068067f to
0cb63af
Compare
DMRobertson
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
LGTM:
dmr on titan in synapse-3 on elara-leitstellentechnik/develop is 📦 v1.98.0rc1 via 🐍 v3.11.6 (matrix-synapse-py3.11) via 🦀 v1.70.0 via 🐏 13GiB/15GiB | 4GiB/8GiB
2023-12-08 16:16:23 ✔ $ generate_signing_key
ed25519 a_mVUl PXgocqQ8m+hOV/e73Se4FRzYKSzsnEgF+CKTB2ugV3A
dmr on titan in synapse-3 on elara-leitstellentechnik/develop is 📦 v1.98.0rc1 via 🐍 v3.11.6 (matrix-synapse-py3.11) via 🦀 v1.70.0 via 🐏 13GiB/15GiB | 4GiB/8GiB
2023-12-08 16:16:28 ✗ 2 USAGE $ generate_signing_key -o arse
dmr on titan in synapse-3 on elara-leitstellentechnik/develop is 📦 v1.98.0rc1 via 🐍 v3.11.6 (matrix-synapse-py3.11) via 🦀 v1.70.0 via 🐏 12GiB/15GiB | 4GiB/8GiB
2023-12-08 16:16:33 ✔ $ stat arse
File: arse
Size: 59 Blocks: 8 IO Block: 4096 regular file
Device: 0,42 Inode: 41513849 Links: 1
Access: (0640/-rw-r-----) Uid: ( 1000/ dmr) Gid: ( 1000/ dmr)
Context: unconfined_u:object_r:user_home_t:s0
Access: 2023-12-08 16:16:32.994926068 +0000
Modify: 2023-12-08 16:16:32.995926073 +0000
Change: 2023-12-08 16:16:32.995926073 +0000
Birth: 2023-12-08 16:16:32.994926068 +0000
dmr on titan in synapse-3 on elara-leitstellentechnik/develop is 📦 v1.98.0rc1 via 🐍 v3.11.6 (matrix-synapse-py3.11) via 🦀 v1.70.0 via 🐏 12GiB/15GiB | 4GiB/8GiB
2023-12-08 16:16:37 ✔ $ cat arse
ed25519 a_BNCz +oIassI35rsZ7DlFLCHnJaCWj4CGNuAoaAmAaxKhVX4
Thank you!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1528.
Fixes #6364.
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.(run the linters)